[Bug-apl] Assertion failed

<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Elias, 
 
correct, except that an UCS8_string is not a string,
despite of its name. 
UCS8_strings
have no terminating 0 byte; the 0-byte is only appended if 
the UCS8_string is
converted to a C string with function c_str(). 
 
/// Jürgen 
 
 

<div class="moz-cite-prefix">On 08/08/2017 09:28 AM, Elias Mårtenson
wrote: 
</div>
<blockquote
cite="mid:CADtN0W+-chxp0w90cWwXB0o+av6cvn1ZWd5yx=***@mail.gmail.com"
type="cite">
<div dir="ltr">Sorry for not replying earlier, I forgot about this
message.
<div> 
</div>
<div>ucs[0] should be OK for an empty string, as that will still
refer to the terminating NUL byte at the end of the string.
Note that an empty string is differetn from a NULL pointer
(the former is a valid string, and the other is not).</div>
<div> 
</div>
<div>Regards,</div>
<div>Elias</div>
</div>
<div class="gmail_extra"> 
<div class="gmail_quote">On 1 August 2017 at 19:04, Juergen
Sauermann <<a moz-do-not-send="true"
href="mailto:***@t-online.de"
target="_blank">***@t-online.de</a>>
wrote: 
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi Elias, 
 
I don't know what Ala'a did. However, looking at: 
 
///
return a UTF8 encoded std:string 
inline std::string to_string(const UCS_string
& ucs) 
{ 
 const UTF8_string utf(ucs); 
 return string((const char *)&utf[0],
utf.size()); 
} 
 
I am not sure what happens if string ucs is
empty (in that case ucs[0] does not 
exist and may be makes &ucs[0] also
0. The std::string constructor then looks 
for the terminating 0 character in a 0-pointer. Using
UTF8:string::c_str() might 
be better. 
 
Also converting a UCS or UTF8 string to std::string
just for outputting it with << may be 
an overkill, since ostream << often
(read: after #include "PrintOperator.hh")
understands 
UCF and UCS strings directly. 
 
/// Jürgen 
 
 
<div class="m_7731621557996309202moz-cite-prefix">On
07/31/2017 02:31 AM, Elias Mårtenson wrote: 
</div>
<blockquote type="cite">
<div dir="auto">Can you tell me exactly what you are
doing in order to reproduce the problem?
<div dir="auto"> 
</div>
<div dir="auto">Regards, </div>
<div dir="auto">Elias </div>
</div>
<div class="gmail_extra"> 
</div>
</blockquote>
 
</div>
</blockquote>
</div>
 
</div>
</blockquote>
 
</body>
</html>

Elias Mårtenson

2017-08-08 10:18:14 UTC

If that's the case, then you are indeed right. It's possible that the
std::string constructor will work, but that would be more out of luck than
anything else.

Regards,
Elias

Hi Elias,
correct, except that an *UCS8_string* is not a string, despite of its
name.
*UCS8_string*s have no terminating 0 byte; the 0-byte is only appended if
the *UCS8_string* is converted to a C string with function *c_str()*.
/// JÃŒrgen
Sorry for not replying earlier, I forgot about this message.
ucs[0] should be OK for an empty string, as that will still refer to the
terminating NUL byte at the end of the string. Note that an empty string is
differetn from a NULL pointer (the former is a valid string, and the other
is not).
Regards,
Elias
On 1 August 2017 at 19:04, Juergen Sauermann <

Hi Elias,
*/// return a UTF8 encoded std:string*
*inline std::string to_string(const UCS_string & ucs)*
*{*
* const UTF8_string utf(ucs);*
* return string((const char *)&utf[0], utf.size());*
*}*
I am not sure what happens if string *ucs* is empty (in that case *ucs[0]
*does not
exist and may be makes *&**ucs[0]* also 0. The std::string constructor
then looks
for the terminating 0 character in a 0-pointer. Using
*UTF8:string::c_str**()* might
be better.
Also converting a UCS or UTF8 string to *std::string* just for
outputting it with << may be
an overkill, since *ostream << *often (read: after *#include
"PrintOperator.hh*") understands
UCF and UCS strings directly.
/// JÃŒrgen
Can you tell me exactly what you are doing in order to reproduce the
problem?
Regards,
Elias

Ala'a Mohammad

2017-08-28 18:10:38 UTC

Hi,

I do not know if this is the same cause, but the assertion seems to be the same

in a new session do the following
- write an incorrect name like 'x.y'
- edit a function like 'z'
- save the function
- edit the z function again, and you get the failed assertion

I'm running the latest APL version from svn:
: apl --version
BUILDTAG:
---------
Project: GNU APL
Version / SVN: 1.7 / 1003M
Build Date: 2017-08-28 18:02:08 UTC
Build OS: Linux 3.13.0-37-generic x86_64
config.status: 'RATIONAL_NUMBERS_WANTED=yes'
Archive SVN: 989

Here is a session sample:
----------------------------------

x.y
VALUE ERROR
x.y
^
∇z
∇z

==============================================================================
Assertion failed: items
in Function: at
in file: ../Simple_string.hh:277

Call stack:

----------------------------------------
-- Stack trace at ../Simple_string.hh:277
----------------------------------------
0x7F2ECE271184
0x7F2EC8FF0BDE connection_loop(void*)
0x7F2EC8FF40FE NetworkConnection::run()
0x7F2EC8FF30CB NetworkConnection::process_command(std::string const&)
0x7F2EC8FECCA7 FnCommand::run_command(NetworkConnection&,
std::vector<std::string, std::allocator<std::string> > const&)
0x45EA0F do_Assert(char const*, char const*, char const*, int)
========================================

SI stack:

Depth: 0
Exec: 0xbaf770
Safe exec: 0
Pmode: ◊ x.y
PC: 0 (5) 'y
Stat: x.y
err_code: 0x30001
thrown at: Symbol.cc:683
e_msg_1: 'VALUE ERROR'
e_msg_2: ' x.y'
e_msg_3: ' ^'

==============================================================================
terminate called after throwing an instance of 'ErrorCode'

Process apl aborted

Hope It Helps

Regards,

Ala'a

Post by Elias MÃ¥rtenson
If that's the case, then you are indeed right. It's possible that the
std::string constructor will work, but that would be more out of luck than
anything else.
Regards,
Elias

Hi Elias,
correct, except that an UCS8_string is not a string, despite of its name.
UCS8_strings have no terminating 0 byte; the 0-byte is only appended if
the UCS8_string is converted to a C string with function c_str().
/// Jürgen
Sorry for not replying earlier, I forgot about this message.
ucs[0] should be OK for an empty string, as that will still refer to the
terminating NUL byte at the end of the string. Note that an empty string is
differetn from a NULL pointer (the former is a valid string, and the other
is not).
Regards,
Elias
On 1 August 2017 at 19:04, Juergen Sauermann

Hi Elias,
/// return a UTF8 encoded std:string
inline std::string to_string(const UCS_string & ucs)
{
const UTF8_string utf(ucs);
return string((const char *)&utf[0], utf.size());
}
I am not sure what happens if string ucs is empty (in that case ucs[0]
does not
exist and may be makes &ucs[0] also 0. The std::string constructor then
looks
for the terminating 0 character in a 0-pointer. Using
UTF8:string::c_str() might
be better.
Also converting a UCS or UTF8 string to std::string just for outputting
it with << may be
an overkill, since ostream << often (read: after #include
"PrintOperator.hh") understands
UCF and UCS strings directly.
/// Jürgen
Can you tell me exactly what you are doing in order to reproduce the
problem?
Regards,
Elias

Ala'a Mohammad

2017-08-28 19:45:16 UTC

Hi,

Trying to reduce the steps above to 'define, save, define' gives the
same thing above. This only happens when the defined function is saved
without a body (saved only with the header).

Network listener started. Connection information: mode:tcp addr:35039
∇x
∇x

==============================================================================
Assertion failed: items
in Function: at
in file: ../Simple_string.hh:277

Call stack:

----------------------------------------
-- Stack trace at ../Simple_string.hh:277
----------------------------------------
0x7F2D7FEEC184
0x7F2D7AC6BBDE connection_loop(void*)
0x7F2D7AC6F0FE NetworkConnection::run()
0x7F2D7AC6E0CB NetworkConnection::process_command(std::string const&)
0x7F2D7AC67CA7 FnCommand::run_command(NetworkConnection&,
std::vector<std::string, std::allocator<std::string> > const&)
0x45EA0F do_Assert(char const*, char const*, char const*, int)
========================================

SI stack:

==============================================================================
terminate called after throwing an instance of 'ErrorCode'

Process apl aborted

Post by Ala'a Mohammad
Hi,
I do not know if this is the same cause, but the assertion seems to be the same
in a new session do the following
- write an incorrect name like 'x.y'
- edit a function like 'z'
- save the function
- edit the z function again, and you get the failed assertion
: apl --version
---------
Project: GNU APL
Version / SVN: 1.7 / 1003M
Build Date: 2017-08-28 18:02:08 UTC
Build OS: Linux 3.13.0-37-generic x86_64
config.status: 'RATIONAL_NUMBERS_WANTED=yes'
Archive SVN: 989
----------------------------------
x.y
VALUE ERROR
x.y
^
∇z
∇z
==============================================================================
Assertion failed: items
in Function: at
in file: ../Simple_string.hh:277
----------------------------------------
-- Stack trace at ../Simple_string.hh:277
----------------------------------------
0x7F2ECE271184
0x7F2EC8FF0BDE connection_loop(void*)
0x7F2EC8FF40FE NetworkConnection::run()
0x7F2EC8FF30CB NetworkConnection::process_command(std::string const&)
0x7F2EC8FECCA7 FnCommand::run_command(NetworkConnection&,
std::vector<std::string, std::allocator<std::string> > const&)
0x45EA0F do_Assert(char const*, char const*, char const*, int)
========================================
Depth: 0
Exec: 0xbaf770
Safe exec: 0
Pmode: ◊ x.y
PC: 0 (5) 'y
Stat: x.y
err_code: 0x30001
thrown at: Symbol.cc:683
e_msg_1: 'VALUE ERROR'
e_msg_2: ' x.y'
e_msg_3: ' ^'
==============================================================================
terminate called after throwing an instance of 'ErrorCode'
Process apl aborted
Hope It Helps
Regards,
Ala'a

Elias Mårtenson

2017-08-30 08:25:54 UTC

I thought JÃŒrgen fixed that? The cuase was apparently my misunderstanding
of how the GNU APL Simple_string works.

Regards,
Elias

Post by Ala'a Mohammad
Hi,
Trying to reduce the steps above to 'define, save, define' gives the
same thing above. This only happens when the defined function is saved
without a body (saved only with the header).
Network listener started. Connection information: mode:tcp addr:35039
âx
âx
============================================================
==================
Assertion failed: items
in Function: at
in file: ../Simple_string.hh:277
----------------------------------------
-- Stack trace at ../Simple_string.hh:277
----------------------------------------
0x7F2D7FEEC184
0x7F2D7AC6BBDE connection_loop(void*)
0x7F2D7AC6F0FE NetworkConnection::run()
0x7F2D7AC6E0CB NetworkConnection::process_command(std::string const&)
0x7F2D7AC67CA7 FnCommand::run_command(NetworkConnection&,
std::vector<std::string, std::allocator<std::string> > const&)
0x45EA0F do_Assert(char const*, char const*, char const*, int)
========================================
============================================================
==================
terminate called after throwing an instance of 'ErrorCode'
Process apl aborted

Post by Ala'a Mohammad
Hi,
I do not know if this is the same cause, but the assertion seems to be

the same

Post by Ala'a Mohammad
in a new session do the following
- write an incorrect name like 'x.y'
- edit a function like 'z'
- save the function
- edit the z function again, and you get the failed assertion
: apl --version
---------
Project: GNU APL
Version / SVN: 1.7 / 1003M
Build Date: 2017-08-28 18:02:08 UTC
Build OS: Linux 3.13.0-37-generic x86_64
config.status: 'RATIONAL_NUMBERS_WANTED=yes'
Archive SVN: 989
----------------------------------
x.y
VALUE ERROR
x.y
^
âz
âz
============================================================

==================

Post by Ala'a Mohammad
Assertion failed: items
in Function: at
in file: ../Simple_string.hh:277
----------------------------------------
-- Stack trace at ../Simple_string.hh:277
----------------------------------------
0x7F2ECE271184
0x7F2EC8FF0BDE connection_loop(void*)
0x7F2EC8FF40FE NetworkConnection::run()
0x7F2EC8FF30CB NetworkConnection::process_command(std::string const&)
0x7F2EC8FECCA7 FnCommand::run_command(NetworkConnection&,
std::vector<std::string, std::allocator<std::string> > const&)
0x45EA0F do_Assert(char const*, char const*, char const*, int)
========================================
Depth: 0
Exec: 0xbaf770
Safe exec: 0
Pmode: â x.y
PC: 0 (5) 'y
Stat: x.y
err_code: 0x30001
thrown at: Symbol.cc:683
e_msg_1: 'VALUE ERROR'
e_msg_2: ' x.y'
e_msg_3: ' ^'
============================================================

==================

Post by Ala'a Mohammad
terminate called after throwing an instance of 'ErrorCode'
Process apl aborted
Hope It Helps
Regards,
Ala'a

Post by Elias MÃ¥rtenson
If that's the case, then you are indeed right. It's possible that the
std::string constructor will work, but that would be more out of luck

than

Post by Elias MÃ¥rtenson
anything else.
Regards,
Elias
On 8 August 2017 at 18:11, Juergen Sauermann <

Hi Elias,
correct, except that an UCS8_string is not a string, despite of its

name.

UCS8_strings have no terminating 0 byte; the 0-byte is only appended if
the UCS8_string is converted to a C string with function c_str().
/// JÃŒrgen
Sorry for not replying earlier, I forgot about this message.
ucs[0] should be OK for an empty string, as that will still refer to

the

terminating NUL byte at the end of the string. Note that an empty

string is

differetn from a NULL pointer (the former is a valid string, and the

other

is not).
Regards,
Elias
On 1 August 2017 at 19:04, Juergen Sauermann

then

looks
for the terminating 0 character in a 0-pointer. Using
UTF8:string::c_str() might
be better.
Also converting a UCS or UTF8 string to std::string just for

outputting

it with << may be
an overkill, since ostream << often (read: after #include
"PrintOperator.hh") understands
UCF and UCS strings directly.
/// JÃŒrgen
Can you tell me exactly what you are doing in order to reproduce the
problem?
Regards,
Elias

Juergen Sauermann

2017-08-30 19:48:20 UTC